Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add routes meta #49

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Add routes meta #49

merged 3 commits into from
Sep 15, 2024

Conversation

arkadiuszbachorski
Copy link
Collaborator

Add pages meta

♻️ Current situation & Problem

Every page uses ENGAGE-HF title. Pages need better meta to make them easier to differentiate.

⚙️ Release Notes

  • Add routes meta

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 27.07%. Comparing base (3168b31) to head (b93411c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
routes/~_dashboard/users/$id.tsx 0.00% 6 Missing ⚠️
routes/~_dashboard/~index.tsx 0.00% 4 Missing ⚠️
routes/~_dashboard/patients/$id/~index.tsx 0.00% 4 Missing ⚠️
routes/~_dashboard/~patients/~index.tsx 0.00% 4 Missing ⚠️
routes/~_dashboard/~patients/~invite.tsx 0.00% 4 Missing ⚠️
routes/~_dashboard/~users/~index.tsx 0.00% 4 Missing ⚠️
routes/~_dashboard/~users/~invite.tsx 0.00% 4 Missing ⚠️
routes/~sign-in/~index.tsx 0.00% 4 Missing ⚠️
routes/~__root.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   27.26%   27.07%   -0.19%     
==========================================
  Files         181      182       +1     
  Lines        6296     6341      +45     
  Branches      299      300       +1     
==========================================
  Hits         1716     1716              
- Misses       4486     4530      +44     
- Partials       94       95       +1
Files with missing lines Coverage Δ
routes/~__root.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/~index.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/patients/$id/~index.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/~patients/~index.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/~patients/~invite.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/~users/~index.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/~users/~invite.tsx 0.00% <0.00%> (ø)
routes/~sign-in/~index.tsx 0.00% <0.00%> (ø)
routes/~_dashboard/users/$id.tsx 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3db050...b93411c. Read the comment docs.

@arkadiuszbachorski arkadiuszbachorski merged commit 190d2ad into main Sep 15, 2024
9 of 10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/handle-page-meta branch September 15, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSchmiedmayer PSchmiedmayer Awaiting requested review from PSchmiedmayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arkadiuszbachorski